Diff view

[Niduank]

No description provided.

[greptile-apps]

Greptile Summary

This PR implements a comprehensive diff view feature that allows users to review and selectively apply text changes generated by AI tools. The implementation includes:

Core Architecture:

• New DiffTool that generates structured text operations (insert, delete, replace) using an optimized LCS-based diff algorithm
• DiffViewModel for managing diff state with SwiftData persistence through DiffRevision and DiffChangeState models
• DiffView component providing an interactive interface with approve/reject controls, keyboard shortcuts, and preview functionality
• NotepadWindowController as a singleton floating panel manager for displaying diff content

Google Docs Integration:

• New service layer with GoogleDocumentServiceProtocol, GoogleDocumentManager, and specialized services (GoogleDocsService, GoogleSheetsService, GoogleSlidesService)
• Complex text reconstruction logic to map between plain text positions and Google Docs API indices
• GoogleDocsParser for converting JSON responses into structured Swift models
• Comprehensive data structures mirroring Google API schemas for Docs, Sheets, and Slides operations

UI Integration:

• ToolCallHandlerView routing system that displays DiffToolView for diff operations
• Diff buttons in toolbars (GeneratedToolbar, QuickEditResponseView) that open the notepad window
• Panel state management updates with isDiffViewActive tracking and panelFrameDidChange delegate notifications
• New color assets for diff visualization (diffBgGreen, diffBgRed, AcceptBG, etc.)

Tool Call Enhancements:

• Enhanced tool execution with duplicate prevention using hash-based tracking
• JSON validation and repair in StreamToolAccumulator for handling partial streaming data
• Automatic diff window opening when diff tools complete execution

The feature integrates seamlessly with the existing chat interface, accessibility parsing system, and panel management architecture while maintaining separation of concerns through proper MVVM patterns.

Confidence score: 2/5

• This PR introduces significant complexity with several concerning implementation issues that could cause crashes or data corruption in production.
• Critical issues include unsafe string manipulation in DiffSegmentUtils, potential index bounds errors in StreamToolAccumulator, system color usage violations in DiffTextView, and complex offset calculations in GoogleDocsService that may fail.
• Files requiring immediate attention: DiffSegmentUtils.swift, StreamToolAccumulator.swift, DiffTextView.swift, GoogleDocsService.swift, DiffViewModel.swift, and ChatEndpointMessagesBuilder.swift.

Context used:

Rule - Use optional chaining syntax action?() instead of explicit nil checking with if-let statements for optional closures. (link)

_{58 files reviewed, 44 comments}

_{Edit Code Review Bot Settings | Greptile}