Skip to content

fix(release): accept authenticated source mismatch - #618

Merged
fishmingyu merged 1 commit into
mainfrom
agent/fix-release-stale-source-smoke
Aug 13, 2026
Merged

fix(release): accept authenticated source mismatch#618
fishmingyu merged 1 commit into
mainfrom
agent/fix-release-stale-source-smoke

Conversation

@fishmingyu

Copy link
Copy Markdown
Member

Summary

Keep the installed Wiki/MCP release smoke aligned with the source-authority error emitted for a stale repository checkout.

Changes

  • accept the manifest-bound source mismatch as a valid fail-closed stale-snapshot rejection
  • add a direct regression test for exit status 2 and the new diagnostic

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Refactoring
  • Performance improvement
  • Tests

Testing

  • Tests pass locally
  • Added new tests for the changes
  • pytest -q test/test_release_artifacts.py --tb=short (14 passed)
  • pre-commit run --files scripts/smoke_release_services.py test/test_release_artifacts.py

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Root cause: the service correctly rejected the stale checkout with status 2 after #588, but the smoke harness recognized only the two legacy diagnostics.

Failure evidence: https://github.com/sysevol-ai/CodeNib/actions/runs/31746352844

The installed-service smoke expected only the legacy stale-index errors, while the source authority now rejects the same stale checkout with the manifest-bound error. Accept that fail-closed message and cover it directly.

Verified with test/test_release_artifacts.py and the changed-file pre-commit hooks.
@github-actions github-actions Bot added the type/test Test-related label Aug 13, 2026
@fishmingyu
fishmingyu marked this pull request as ready for review August 13, 2026 21:51
@fishmingyu
fishmingyu merged commit de521ee into main Aug 13, 2026
16 checks passed
@fishmingyu
fishmingyu deleted the agent/fix-release-stale-source-smoke branch August 13, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/test Test-related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant