fix(zlib): compile + test cleanly when disabled#54
Merged
szaghi merged 3 commits intoszaghi:masterfrom Mar 13, 2026
Merged
Conversation
Install zlib dev package on Ubuntu runners and run a second FoBiS build with VTKFORTRAN_USE_ZLIB enabled. Also guard zlib bindings so zlib-off builds don't require linking -lz.
Wrap compress2 call in VTKFORTRAN_USE_ZLIB guard so FoBiS zlib-off mode compiles.
Avoid running the RAW-ZLIB writer when VTKFORTRAN_USE_ZLIB is not defined (coverage mode), preventing runtime errors from continuing after failed initialize.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#53 didn’t compile when zlib is disabled (coverage/zlib-OFF mode): 'compress2' was still referenced while its interface is preprocessed out.
This PR:
Wraps the 'compress2' call in #ifdef VTKFORTRAN_USE_ZLIB.
Makes 'vtk_fortran_write_vtu_zlib' skip when zlib is not enabled (instead of crashing).
I also tried to fix the CI tests, feel free to adapt to match your other repos.