Open
Conversation
ed06ab8 to
54466cf
Compare
Author
|
I am so sorry for the repeated force pushes, I had some serious troubles correctly using my gpg key.... I apologise sincerely for that spam, I am doing this for the first time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This addresses issue #56 when building the library with the Fortran Package Manager. The fpm configuration file is updated to allow use of profiles and extensive features to improve build quality of library when using fpm.
Requires at least fpm in version 0.13.0!
Motivation
The current fpm configuration file does not allow optimal compiler flags and features. This may cause issues especially when compiling with ifx. Suboptimal compiler flags caused SEGFAULT when array sizes were too big.
Closes #56
Changes
-added features and profiles to fpm.toml
-compiler flags transferred based on makefile
-Readme updated to reflect new fpm capability
Important note:
I could not make fpm test to work because fpm expects
testsdirectory to be located in top level and I did not manage to set up custom tests. This was already not working previously.Checklist
ctest,run_tests.sh, orfpm test)