Skip to content

fix: propagate HDF5_IS_PARALLEL to parent scope for SZ3Config #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayzk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: propagate HDF5_IS_PARALLEL to parent scope for SZ3Config #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tools/H5Z-SZ3/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ if (${HDF5_IS_PARALLEL})
target_link_libraries(hdf5sz3
PUBLIC MPI::MPI_CXX)
endif ()
set(HDF5_IS_PARALLEL ${HDF5_IS_PARALLEL} PARENT_SCOPE)
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When BUILD_H5Z_FILTER is OFF (the default), this subdirectory is not included (main CMakeLists.txt line 95-98), so HDF5_IS_PARALLEL remains undefined. The configure_package_config_file call (main CMakeLists.txt line 122) will substitute @HDF5_IS_PARALLEL@ with an empty string in SZ3Config.cmake.in line 6, resulting in invalid CMake syntax if(). This will cause errors for downstream projects using find_package(SZ3) when SZ3 is built with the default configuration.

Consider initializing HDF5_IS_PARALLEL to FALSE in the main CMakeLists.txt before line 95 (the BUILD_H5Z_FILTER conditional), ensuring it has a valid value even when the H5Z-SZ3 subdirectory is not included.

Copilot uses AI. Check for mistakes.

target_include_directories(hdf5sz3
PUBLIC
Expand Down
Loading