Skip to content

Add SideShift.ai reporting#1

Open
szgergely wants to merge 22 commits intomasterfrom
sideshift
Open

Add SideShift.ai reporting#1
szgergely wants to merge 22 commits intomasterfrom
sideshift

Conversation

@szgergely
Copy link
Copy Markdown
Owner

@szgergely szgergely commented Oct 5, 2020

Create the SideShift reporting function and use it in the reporter.js file.

@nilswx nilswx changed the title Sideshift Add SideShift.ai reporting Oct 5, 2020
@nilswx nilswx self-requested a review October 5, 2020 06:38
Comment thread src/reporter.js Outdated
Comment thread src/sideshift.js Outdated
Comment thread src/sideshift.js
Comment thread src/sideshift.js Outdated
Comment thread src/sideshift.js Outdated
Comment thread src/sideshift.js Outdated
Comment thread src/sideshift.js Outdated
@nilswx
Copy link
Copy Markdown
Collaborator

nilswx commented Oct 5, 2020

config.sample.json is missing now. Must be because you renamed it to config.json.

Please restore config.sample.json.

@nilswx
Copy link
Copy Markdown
Collaborator

nilswx commented Oct 5, 2020

Some past tense commits:

  • Refactored string conversion
  • Changed quoteId to id

Remember: always 'Use imperative tense' for commit messages.

https://chris.beams.io/posts/git-commit/#seven-rules

Repository owner deleted a comment from szgergely Oct 5, 2020
Comment thread src/sideshift.js Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants