Skip to content

fix: match destinationSettler to counterpart#196

Closed
rymcol wants to merge 1 commit into
canaryfrom
bugfix/audit/c-3
Closed

fix: match destinationSettler to counterpart#196
rymcol wants to merge 1 commit into
canaryfrom
bugfix/audit/c-3

Conversation

@rymcol

@rymcol rymcol commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Description

Enforces destinationSettler == counterpart

Motivation and Context

Prevents edge cases where a user could specify an incorrect settler

How Has This Been Tested?

manually

Types of changes (remove all unchecked types)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Style (style only changes)
  • Docs
  • Refactor (code that does not add new functionality nor fixes a bug)

Checklist:

  • If my change requires a change to the documentation, I have updated the documentation accordingly, and in either case, have checked this box to attest to my assessment of this requirement with regard to my change.
  • If my change requires additions or updates to any deployment scripts to ensure that the protocol is functional (Makefile, Dockerfile, Forge Script, etc.), I have made these changes, and in either case, have checked this box to attest to my assessment of this requirement with regard to my change.
  • If my change requires additional test coverage, I have created those tests accordingly, and in either case, have checked this box to attest to my assessment of this requirement with regard to my change.

@rymcol rymcol self-assigned this Sep 24, 2025
@rymcol rymcol requested review from evchip and kss-t1 September 24, 2025 17:07

@evchip evchip left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please run forge fmt to lint


if (orderData.originDomain != localDomain) revert InvalidOriginDomain(orderData.originDomain);

// Ensure destinationSettler matches counterpart

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment seems superfluous

@rymcol rymcol closed this Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants