Skip to content

Refactor: improve sealed bid auction server recovery#222

Merged
evchip merged 15 commits into
canaryfrom
refactor/send-open-event-log-to-filler
Dec 22, 2025
Merged

Refactor: improve sealed bid auction server recovery#222
evchip merged 15 commits into
canaryfrom
refactor/send-open-event-log-to-filler

Conversation

@evchip

@evchip evchip commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

Description

Overall just adding more robustness and defensive programming to the sealed-bid-auction app:

  • add try/catch block to auction call
  • add optional "from" blocks as env vars for historical event logging. these are useful if we miss events and want to rewind
  • send Open event metadata to solvers so that they do not have to re-fetch this event onchain themselves. This was unnecessary complexity that made it difficult to replay missed open intent events.

Motivation and Context

the sealed bid auction server experienced a failure fetching arbitrum Open intent events that became difficult to recover from. These changes do not contribute to making these kind of failures less likely, but they do help us to more easily manually recover from a failure

How Has This Been Tested?

Yes, manually tested in prod.

Types of changes (remove all unchecked types)

  • New feature (non-breaking change which adds functionality)

Checklist:

  • If my change requires a change to the documentation, I have updated the documentation accordingly, and in either case, have checked this box to attest to my assessment of this requirement with regard to my change.
  • If my change requires additions or updates to any deployment scripts to ensure that the protocol is functional (Makefile, Dockerfile, Forge Script, etc.), I have made these changes, and in either case, have checked this box to attest to my assessment of this requirement with regard to my change.
  • If my change requires additional test coverage, I have created those tests accordingly, and in either case, have checked this box to attest to my assessment of this requirement with regard to my change.

Comment thread contracts/deployments/7683/v0.9.1.json
@evchip evchip changed the title Refactor/send open event log to filler Refactor: improve sealed bid auction server recovery Dec 18, 2025
@evchip evchip requested a review from OrestTa December 18, 2025 20:47
@evchip evchip self-assigned this Dec 18, 2025
@OrestTa OrestTa requested a review from kss-t1 December 20, 2025 11:23
Comment thread tee-apps/sealed-bid-auction/.env.template
@kss-t1

kss-t1 commented Dec 22, 2025

Copy link
Copy Markdown
Member

Asked for changes because I am not a fan of rewinding missed Intents.

Rest of the changes look good.

@kss-t1 kss-t1 self-requested a review December 22, 2025 13:55

@kss-t1 kss-t1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after consulting - rewinding might be useful, and the Filler is able to handle double processing of an intent gracefully.

@evchip evchip removed the request for review from OrestTa December 22, 2025 13:58
@evchip evchip merged commit 59de3fd into canary Dec 22, 2025
4 checks passed
@evchip evchip deleted the refactor/send-open-event-log-to-filler branch December 22, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants