Refactor: improve sealed bid auction server recovery#222
Merged
Conversation
…end-open-event-log-to-filler
…or/send-open-event-log-to-filler
evchip
commented
Dec 18, 2025
kss-t1
requested changes
Dec 22, 2025
Member
|
Asked for changes because I am not a fan of rewinding missed Intents. Rest of the changes look good. |
kss-t1
approved these changes
Dec 22, 2025
kss-t1
left a comment
Member
There was a problem hiding this comment.
Approved after consulting - rewinding might be useful, and the Filler is able to handle double processing of an intent gracefully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Overall just adding more robustness and defensive programming to the sealed-bid-auction app:
Openevent metadata to solvers so that they do not have to re-fetch this event onchain themselves. This was unnecessary complexity that made it difficult to replay missed open intent events.Motivation and Context
the sealed bid auction server experienced a failure fetching arbitrum
Openintent events that became difficult to recover from. These changes do not contribute to making these kind of failures less likely, but they do help us to more easily manually recover from a failureHow Has This Been Tested?
Yes, manually tested in prod.
Types of changes (remove all unchecked types)
Checklist: