Skip to content

Feat/sealed bid auction/ws outage resistance#224

Merged
kss-t1 merged 8 commits into
canaryfrom
feat/sealed-bid-auction/ws-outage-resistance
Dec 31, 2025
Merged

Feat/sealed bid auction/ws outage resistance#224
kss-t1 merged 8 commits into
canaryfrom
feat/sealed-bid-auction/ws-outage-resistance

Conversation

@kss-t1

@kss-t1 kss-t1 commented Dec 31, 2025

Copy link
Copy Markdown
Member

Description

Makes our Sealed Bid Auction Server resistant to WebSocket connection dropping due to external factors by:

  • persistently reconnecting after connection drops
  • processing missed blocks after WS reconnects

Also, removes await on processing a single intent auction, so that next intents are processed in parallel. Without that, if no solver is found for an intent then processing other intents is blocked until we reach fillDeadline for that intents (which could be a long time) .

Motivation and Context

Because we only tried to reconnect 5 times when WS connection dropped, which resulted in no longer listening to inbound intents. Also, we were missing intents every now and then if they happened when WS connection was down.

How Has This Been Tested?

tested on local, against mainnet contracts!

Types of changes (remove all unchecked types)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Style (style only changes)
  • Docs
  • Refactor (code that does not add new functionality nor fixes a bug)

Checklist:

  • If my change requires a change to the documentation, I have updated the documentation accordingly, and in either case, have checked this box to attest to my assessment of this requirement with regard to my change.
  • If my change requires additions or updates to any deployment scripts to ensure that the protocol is functional (Makefile, Dockerfile, Forge Script, etc.), I have made these changes, and in either case, have checked this box to attest to my assessment of this requirement with regard to my change.
  • If my change requires additional test coverage, I have created those tests accordingly, and in either case, have checked this box to attest to my assessment of this requirement with regard to my change.

@kss-t1 kss-t1 marked this pull request as draft December 31, 2025 12:44
@kss-t1 kss-t1 marked this pull request as ready for review December 31, 2025 16:44
@kss-t1 kss-t1 requested a review from evchip December 31, 2025 16:44

@evchip evchip left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Only thing I think could be improved is a PagerDuty hook. But I have that in my open PR. Can rework it once we merge this in

@kss-t1 kss-t1 merged commit 82e61ec into canary Dec 31, 2025
8 checks passed
@kss-t1 kss-t1 deleted the feat/sealed-bid-auction/ws-outage-resistance branch December 31, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants