Feature gRPC by tab · Pull Request #47 · tab/loki

tab · 2025-04-04T14:08:31Z

Use proto as submodule
Add gRPC authentication interceptor
Add gRPC permission service
Add gRPC scope service
Add gRPC role service
Add gRPC token service
Add gRPC user service
Use RSA keys for JWT signing
Add integration testing framework and workflow
Update README and docs

codecov-commenter · 2025-04-04T14:10:53Z

Codecov Report

Attention: Patch coverage is 87.99232% with 125 lines in your changes missing coverage. Please review.

Project coverage is 82.13%. Comparing base (3adc4bc) to head (b11f31f).

Files with missing lines	Patch %	Lines
internal/app/rpcs/services/roles.go	83.75%	21 Missing and 5 partials ⚠️
internal/app/rpcs/services/users.go	85.31%	21 Missing and 5 partials ⚠️
internal/config/server/grpc.go	74.02%	15 Missing and 5 partials ⚠️
internal/app/app.go	0.00%	19 Missing ⚠️
internal/app/rpcs/services/permissions.go	91.24%	9 Missing and 3 partials ⚠️
internal/app/rpcs/services/scopes.go	91.24%	9 Missing and 3 partials ⚠️
internal/app/rpcs/services/tokens.go	93.33%	3 Missing and 1 partial ⚠️
internal/config/middlewares/logger.go	92.10%	2 Missing and 1 partial ⚠️
internal/app/services/roles.go	81.81%	2 Missing ⚠️
internal/config/middlewares/telemetry.go	85.71%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   81.51%   82.13%   +0.62%     
==========================================
  Files          57       63       +6     
  Lines        2732     3230     +498     
==========================================
+ Hits         2227     2653     +426     
- Misses        425      478      +53     
- Partials       80       99      +19

Files with missing lines	Coverage Δ
internal/app/rpcs/interceptors/authentication.go	`100.00% <100.00%> (ø)`
internal/app/rpcs/interceptors/logger.go	`100.00% <100.00%> (ø)`
internal/app/rpcs/interceptors/trace.go	`100.00% <100.00%> (ø)`
internal/app/rpcs/registry.go	`100.00% <100.00%> (ø)`
internal/app/services/authentication.go	`100.00% <ø> (ø)`
internal/app/services/authentication/mobileid.go	`100.00% <ø> (ø)`
internal/app/services/authentication/smartid.go	`100.00% <ø> (ø)`
internal/app/services/permissions.go	`100.00% <100.00%> (+6.97%)`	⬆️
internal/app/services/scopes.go	`100.00% <100.00%> (+34.88%)`	⬆️
internal/app/services/sessions.go	`81.81% <ø> (ø)`
... and 24 more

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

arttet · 2025-04-15T15:41:49Z

@@ -0,0 +1,145 @@
+LOKI_REPO ?= $(shell pwd)/../../loki


Suggested change

LOKI_REPO ?= $(shell pwd)/../../loki

LOKI_HOME ?= ""

LOKI_REPO ?= ${LOKI_HOME}/loki

arttet · 2025-04-15T15:42:05Z

+DB_HOST = localhost
+DB_PORT = 5432
+
+GOOSE_DRIVER = postgres


Suggested change

GOOSE_DRIVER = postgres

GOOSE_DRIVER ?= postgres

arttet · 2025-04-15T15:45:16Z

+local uuid = require("uuid")
+
+uuid.randomseed(os.time())
+


Please find more suitable package. Not .github

arttet · 2025-04-15T15:51:00Z

@@ -0,0 +1,3 @@
+[submodule "proto"]
+	path = proto
+	url = git@github.com:tab/loki-proto.git


go_package

option go_package = "https://github.com/tab/loki/internal/app/rpcs/proto/sso/v1;ssov1";

arttet · 2025-04-15T15:53:16Z

+```sh
+# Generate CA
+openssl genrsa -out certs/ca.key 4096
+openssl req -new -x509 -key certs/ca.key -sha256 -subj "/CN=Loki CA" -out certs/ca.pem -days 3650


Suggested change

openssl req -new -x509 -key certs/ca.key -sha256 -subj "/CN=Loki CA" -out certs/ca.pem -days 3650

openssl req -new -x509 -key certs/ca.key -sha256 -subj '/CN=Loki CA' -out certs/ca.pem -days 3650

arttet · 2025-04-15T15:58:09Z

+	}, nil
+}
+
+func (p *permissionsService) Update(ctx context.Context, req *proto.UpdatePermissionRequest) (*proto.UpdatePermissionResponse, error) {


Suggested change

func (p *permissionsService) Update(ctx context.Context, req *proto.UpdatePermissionRequest) (*proto.UpdatePermissionResponse, error) {

func (p *permissionsService) UpdatePermission(ctx context.Context, req *proto.UpdatePermissionRequest) (*proto.UpdatePermissionResponse, error) {

Added gRPC authentication interceptor Added permission service with CRUD operations for managing user permissions

Added scope service with CRUD operations for managing application scopes

Added role service with CRUD operations for managing user roles

Added token service with List and Delete operations for managing user JSON web tokens

Added user service with CRUD operations for managing users

Added new error constants for failed record creation, updating, deletion, and not found errors

Updated the JWT implementation to use RSA keys instead of a single secret key for signing

… and mTLS certificates

Deleted the backoffice controllers and tests REST API replaced with gRPC

Added sections for generating JWT signing keys and mTLS certificates Added related repositories section

…certificate

…tories

tab force-pushed the feature/grpc branch from b6c2558 to 10a3718 Compare April 5, 2025 18:23

arttet reviewed Apr 15, 2025

View reviewed changes

tab added 18 commits April 20, 2025 12:25

chore(proto): Add proto submodule

e6d798d

feat(grpc) Add gRPC authentication interceptor and permission service

a3bf268

Added gRPC authentication interceptor Added permission service with CRUD operations for managing user permissions

feat(grpc) Add gRPC scope service

71fd9b2

Added scope service with CRUD operations for managing application scopes

feat(grpc) Add gRPC role service

c66bf48

Added role service with CRUD operations for managing user roles

feat(grpc) Add gRPC token service

c9baa3e

Added token service with List and Delete operations for managing user JSON web tokens

feat(grpc) Add gRPC user service

400e652

Added user service with CRUD operations for managing users

fix(errors): Add new error constants for record CRUD operations

eca58fb

Added new error constants for failed record creation, updating, deletion, and not found errors

refactor(grpc): Update errors handling

2113423

chore(codecov): Update codecov ignore patterns

b88d57d

refactor(config): Remove SECRET_KEY and use RSA keys for JWT signing

1249b35

Updated the JWT implementation to use RSA keys instead of a single secret key for signing

chore(grpc) Use FindRoleDetailsById and FindUserDetailsById methods

51940e3

refactor(logger): JSON structured logging

45aa271

chore(env): Add gRPC address to .env.development

3c98844

docs(certificates): Add documentation for generating JWT signing keys…

76c0c4b

… and mTLS certificates

refactor(backoffice): Remove backoffice controllers

468f8d6

Deleted the backoffice controllers and tests REST API replaced with gRPC

feat(api): Remove backoffice API endpoints from OpenAPI specification

bcf8538

docs(README): Update README

fe4b258

Added sections for generating JWT signing keys and mTLS certificates Added related repositories section

feat(ci): Add integration testing framework and workflow

ecbdc58

tab force-pushed the feature/grpc branch from a2f6098 to ecbdc58 Compare April 20, 2025 09:31

tab added 2 commits April 20, 2025 12:36

chore(certs): Use single quotes in OpenSSL command for generating CA …

614d80d

…certificate

chore(Makefile): Update environment variable handling for Loki reposi…

b11f31f

…tories

tab merged commit 18e00e1 into master May 4, 2025
1 of 3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature gRPC#47

Feature gRPC#47
tab merged 20 commits into
masterfrom
feature/grpc

tab commented Apr 4, 2025 •

edited

Loading

Uh oh!

codecov-commenter commented Apr 4, 2025 •

edited

Loading

Uh oh!

arttet Apr 15, 2025

Uh oh!

arttet Apr 15, 2025

Uh oh!

arttet Apr 15, 2025

Uh oh!

arttet Apr 15, 2025

Uh oh!

arttet Apr 15, 2025

Uh oh!

arttet Apr 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	LOKI_REPO ?= $(shell pwd)/../../loki
	LOKI_HOME ?= ""
	LOKI_REPO ?= ${LOKI_HOME}/loki

	openssl req -new -x509 -key certs/ca.key -sha256 -subj "/CN=Loki CA" -out certs/ca.pem -days 3650
	openssl req -new -x509 -key certs/ca.key -sha256 -subj '/CN=Loki CA' -out certs/ca.pem -days 3650

	func (p permissionsService) Update(ctx context.Context, req proto.UpdatePermissionRequest) (*proto.UpdatePermissionResponse, error) {
	func (p permissionsService) UpdatePermission(ctx context.Context, req proto.UpdatePermissionRequest) (*proto.UpdatePermissionResponse, error) {

		local uuid = require("uuid")

		uuid.randomseed(os.time())

Conversation

tab commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

arttet Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

arttet Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

arttet Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

arttet Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

arttet Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

arttet Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tab commented Apr 4, 2025 •

edited

Loading

codecov-commenter commented Apr 4, 2025 •

edited

Loading