fix: Click 8.4+ compatibility for ParameterSource detection - #1
Merged
Conversation
Click 8.4.0 changed ParameterSource from a string-valued enum to an integer-valued enum. str(ParameterSource.COMMANDLINE) now returns "2" instead of "ParameterSource.COMMANDLINE", causing source detection to silently fail — all CLI values were treated as DEFAULT. Use .name attribute instead of str() for reliable enum member name comparison across all Click 8.x versions. Also loosen test assertions for Click's changed error message format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParameterSourcefrom a string-valued enum to an integer-valued enum.str(ParameterSource.COMMANDLINE)now returns"2"instead of"ParameterSource.COMMANDLINE", causing wry's source detection to silently fail — all CLI-provided values were treated as DEFAULT..nameattribute instead ofstr()for reliable enum member name comparison across all Click 8.x versions.'--opt'vs: --opt).Test plan