Skip to content

[ci] Add benchmark to postsubmit workflow#3220

Merged
yolo2themoon merged 5 commits intotaichi-dev:masterfrom
yolo2themoon:postsubmit_benchmark
Oct 25, 2021
Merged

[ci] Add benchmark to postsubmit workflow#3220
yolo2themoon merged 5 commits intotaichi-dev:masterfrom
yolo2themoon:postsubmit_benchmark

Conversation

@yolo2themoon
Copy link
Copy Markdown
Contributor

Related issue = #2632

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 18, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc ready!

🔨 Explore the source changes: 1266ce1

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61763b9c158fca0007a52568

😎 Browse the preview: https://deploy-preview-3220--jovial-fermat-aa59dc.netlify.app

Copy link
Copy Markdown
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread .github/workflows/postsubmit.yml Outdated
Comment thread .github/workflows/postsubmit.yml Outdated
Comment thread benchmarks/misc/run.py Outdated
Comment thread benchmarks/misc/run.py Outdated
Copy link
Copy Markdown
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (for postsubmit workflow it's always good to test in test_actions first ;)

Comment thread .github/workflows/postsubmit.yml Outdated

performance_monitoring:
name: Performance monitoring (NVGPU)
needs: check_code_format
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no check_code_format in the postsubmit workflow right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I used presubmit workflow in test_actions to test it before. 😆
[ci] Benchmark presubmit test

Copy link
Copy Markdown
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants