feat(ws): add read pump for disconnect detection, GetContext, Level.String#24
Merged
Merged
Conversation
…tring - Add WebSocket read pump in LogSocketHandler so client disconnects are detected promptly instead of only on the next WriteMessage call - Add Client.GetContext(ctx) for context-aware blocking reads - Implement fmt.Stringer on Level type (Level.String()) - Add tests for GetContext, GetContext cancellation, and Level.String()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
WebSocket read pump
The
LogSocketHandlerpreviously never read from the WebSocket connection. This meant client disconnects were only detected whenWriteMessagefailed — which could be delayed indefinitely if no logs were being produced. A goroutine now continuously reads from the connection, and cancels a context when the client disconnects.Client.GetContext(ctx)New method that blocks until either a log entry arrives or the context is cancelled. Used by the WebSocket handler to cleanly exit when the read pump detects a disconnect. Also useful for any caller that needs cancellation support.
Level.String()Implements
fmt.StringeronLevel, returning the human-readable level name ("INFO", "WARN", etc.).Tests
TestGetContext— verifies cancelled context returnsfalseTestGetContextReceivesEntry— verifies normal entry deliveryTestLevelString— verifies all level names including unknown