feat: add configurable acceptable warning threshold#7
Merged
Merged
Conversation
Contributor
Code Metrics Report
Code coverage of files in pull request scope (59.0%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how lint configuration is structured and introduces a new feature to control the acceptable number of lint warnings before failing. The main changes are the introduction of an
acceptablethreshold for warnings, the grouping of all lint rules under a newrulesfield, and updates to both the code and documentation to reflect these changes.Configuration structure improvements:
acceptablefield to the lint configuration, allowing users to specify the maximum number of lint warnings before the command fails. This is documented in theREADME.mdand implemented in the lint command logic. [1] [2] [3] [4]rulesfield within thelintsection, replacing the previous flat structure. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Code and test updates:
rulesfield, ensuring consistency and correctness. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]rulesfield, ensuring tests reflect the new configuration structure and continue to validate linting logic. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]Documentation:
README.mdto document the newacceptableoption and the new structure for specifying lint rules. [1] [2]Other:
cmd/lint.go.