fix(skills): rename bundled dir to agent-skills to fix gh skill install duplicates#1208
Open
toiroakr wants to merge 1 commit into
Open
fix(skills): rename bundled dir to agent-skills to fix gh skill install duplicates#1208toiroakr wants to merge 1 commit into
toiroakr wants to merge 1 commit into
Conversation
… install duplicates `gh skill install` uses a recursive `**/skills/*/SKILL.md` match and was picking up both `skills/tailor-sdk/` (the public mirror) and `packages/sdk/skills/tailor-sdk/` (the npm bundle), reporting a name conflict. Rename the bundled copy to `packages/sdk/agent-skills/` so only the root `skills/` mirror is discovered. Both `gh skill install tailor-platform/sdk` and `npx skills add <repo>` now resolve a single skill, while `npx tailor-sdk skills install` continues to use the bundled `agent-skills/` path inside the published package.
🦋 Changeset detectedLatest commit: 59d7e0e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
⚡ pkg.pr.new@tailor-platform/sdk@tailor-platform/create-sdk
|
Code Metrics Report (packages/sdk)
Details | | main (b2bd4aa) | #1208 (05c5451) | +/- |
|--------------------|----------------|-----------------|------|
| Coverage | 62.3% | 62.3% | 0.0% |
| Files | 364 | 364 | 0 |
| Lines | 12773 | 12773 | 0 |
| Covered | 7967 | 7967 | 0 |
| Code to Test Ratio | 1:0.4 | 1:0.4 | 0.0 |
| Code | 83913 | 83913 | 0 |
| Test | 35136 | 35136 | 0 |Code coverage of files in pull request scope (57.1% → 57.1%)
SDK Configure Bundle Size
Runtime Performance
Type Performance (instantiations)
Reported by octocov |
📖 Docs Consistency Check✅ No inconsistencies found between documentation and implementation. Checked areas: Implementation Changes
Documentation Review
SummaryThe only user-facing documentation that mentioned the internal directory path was |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh skill install tailor-platform/sdkpreviously failed with "cannot install skills with conflicting names" because gh's recursive**/skills/*/SKILL.mdmatch discovered bothskills/tailor-sdk/(the public mirror) andpackages/sdk/skills/tailor-sdk/(the npm bundle).packages/sdk/agent-skills/so only the repo-rootskills/mirror is picked up by gh. Bothgh skill installandnpx skills add <repo>now resolve a single skill.npx tailor-sdk skills installcontinues to work via the bundledagent-skills/path inside the published package;package.jsonfiles, the install command'sresolveBundledSkillsDir, and the skills-sync workflow are all pointed at the new directory.