Skip to content

fix(skills): rename bundled dir to agent-skills to fix gh skill install duplicates#1208

Open
toiroakr wants to merge 1 commit into
mainfrom
fix/skill-list
Open

fix(skills): rename bundled dir to agent-skills to fix gh skill install duplicates#1208
toiroakr wants to merge 1 commit into
mainfrom
fix/skill-list

Conversation

@toiroakr
Copy link
Copy Markdown
Contributor

Summary

  • gh skill install tailor-platform/sdk previously failed with "cannot install skills with conflicting names" because gh's recursive **/skills/*/SKILL.md match discovered both skills/tailor-sdk/ (the public mirror) and packages/sdk/skills/tailor-sdk/ (the npm bundle).
  • Rename the bundled copy to packages/sdk/agent-skills/ so only the repo-root skills/ mirror is picked up by gh. Both gh skill install and npx skills add <repo> now resolve a single skill.
  • npx tailor-sdk skills install continues to work via the bundled agent-skills/ path inside the published package; package.json files, the install command's resolveBundledSkillsDir, and the skills-sync workflow are all pointed at the new directory.

… install duplicates

`gh skill install` uses a recursive `**/skills/*/SKILL.md` match and was
picking up both `skills/tailor-sdk/` (the public mirror) and
`packages/sdk/skills/tailor-sdk/` (the npm bundle), reporting a name
conflict. Rename the bundled copy to `packages/sdk/agent-skills/` so
only the root `skills/` mirror is discovered.

Both `gh skill install tailor-platform/sdk` and `npx skills add <repo>`
now resolve a single skill, while `npx tailor-sdk skills install`
continues to use the bundled `agent-skills/` path inside the published
package.
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 20, 2026

🦋 Changeset detected

Latest commit: 59d7e0e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@tailor-platform/sdk Patch
@tailor-platform/create-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2026

⚡ pkg.pr.new

@tailor-platform/sdk

pnpm add https://pkg.pr.new/@tailor-platform/sdk@59d7e0e
pnpm dlx https://pkg.pr.new/@tailor-platform/sdk@59d7e0e --help

@tailor-platform/create-sdk

pnpm add https://pkg.pr.new/@tailor-platform/create-sdk@59d7e0e
pnpm dlx https://pkg.pr.new/@tailor-platform/create-sdk@59d7e0e my-app

commit: 59d7e0e

@github-actions
Copy link
Copy Markdown

Code Metrics Report (packages/sdk)

main (b2bd4aa) #1208 (05c5451) +/-
Coverage 62.3% 62.3% 0.0%
Code to Test Ratio 1:0.4 1:0.4 0.0
Details
  |                    | main (b2bd4aa) | #1208 (05c5451) | +/-  |
  |--------------------|----------------|-----------------|------|
  | Coverage           |          62.3% |           62.3% | 0.0% |
  |   Files            |            364 |             364 |    0 |
  |   Lines            |          12773 |           12773 |    0 |
  |   Covered          |           7967 |            7967 |    0 |
  | Code to Test Ratio |          1:0.4 |           1:0.4 |  0.0 |
  |   Code             |          83913 |           83913 |    0 |
  |   Test             |          35136 |           35136 |    0 |

Code coverage of files in pull request scope (57.1% → 57.1%)

Files Coverage +/- Status
packages/sdk/src/cli/commands/skills/install.ts 57.1% 0.0% modified

SDK Configure Bundle Size

main (b2bd4aa) #1208 (05c5451) +/-
configure-index-size 18KB 18KB 0KB
dependency-chunks-size 33.52KB 33.52KB 0KB
total-bundle-size 51.51KB 51.51KB 0KB

Runtime Performance

main (b2bd4aa) #1208 (05c5451) +/-
Generate Median 2,279ms 2,329ms 50ms
Generate Max 2,294ms 2,567ms 273ms
Apply Build Median 2,317ms 2,325ms 8ms
Apply Build Max 2,453ms 2,355ms -98ms

Type Performance (instantiations)

main (b2bd4aa) #1208 (05c5451) +/-
tailordb-basic 35,130 35,130 0
tailordb-optional 3,841 3,841 0
tailordb-relation 7,428 7,428 0
tailordb-validate 2,566 2,566 0
tailordb-hooks 5,767 5,767 0
tailordb-object 12,136 12,136 0
tailordb-enum 2,462 2,462 0
resolver-basic 9,424 9,424 0
resolver-nested 26,111 26,111 0
resolver-array 18,187 18,187 0
executor-schedule 4,234 4,234 0
executor-webhook 873 873 0
executor-record 8,166 8,166 0
executor-resolver 4,369 4,369 0
executor-operation-function 869 869 0
executor-operation-gql 869 869 0
executor-operation-webhook 888 888 0
executor-operation-workflow 1,714 1,714 0

Reported by octocov

@toiroakr toiroakr marked this pull request as ready for review May 20, 2026 16:53
@toiroakr toiroakr requested a review from remiposo as a code owner May 20, 2026 16:53
@claude
Copy link
Copy Markdown

claude Bot commented May 20, 2026

📖 Docs Consistency Check

✅ No inconsistencies found between documentation and implementation.

Checked areas:

Implementation Changes

  • ✅ Directory renamed: packages/sdk/skills/packages/sdk/agent-skills/
  • ✅ Source code updated: install.ts now resolves to agent-skills/ with explanatory comments
  • ✅ Tests updated: assertions reference new directory path
  • ✅ Package config updated: package.json files list includes agent-skills
  • ✅ CI workflow updated: .github/workflows/skills-sync-check.yml uses new path
  • ✅ Symlink updated: .claude/skills/tailor-sdk points to new location

Documentation Review

  • packages/sdk/README.md (line 63): Updated to reference node_modules/@tailor-platform/sdk/agent-skills
  • packages/sdk/docs/cli/skills.md: No internal path references (only high-level command descriptions)
  • packages/sdk/docs/cli-reference.md: No internal path references
  • CLAUDE.md: No skills directory path references
  • docs/ (developer guides): No skills directory references
  • skills/tailor-sdk/SKILL.md: No internal path references (only references to node_modules/@tailor-platform/sdk/docs/*)
  • example/ directory: No skills directory references
  • Source code comments: Correctly explain the rationale for using agent-skills name

Summary

The only user-facing documentation that mentioned the internal directory path was packages/sdk/README.md, which was correctly updated in this PR. All CLI documentation describes behavior at a high level without exposing internal implementation details. The change is fully consistent across code, tests, configuration, and documentation.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants