Skip to content

Conversation

@timtailscale
Copy link

add search endpoint with support for owner filtering, the all page now uses the search template with the expectation that all becomes a "search" once search is fully implemented

updates #98

add search endpoint with support for owner filtering, the all page
now uses the search template with the expectation that all becomes
a "search" once search is fully implemented

updates #98

Signed-off-by: Tim Walters <tim@tailscale.com>
Copy link

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by comment for your Wednesday! Please ignore unless it provides value to you.

}

sort.Slice(links, func(i, j int) bool {
return links[i].Short < links[j].Short
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't sorting be user-defined? I might want to change the sorting (e.g. to created date) in the UI. Should that be supported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants