ts_tunnel: move packet queue storage back into Peer - #379
Merged
Merged
Conversation
danderson
force-pushed
the
push-xksxswkmwqvq
branch
3 times, most recently
from
August 19, 2026 00:34
53e2593 to
17dd11d
Compare
nrc
approved these changes
Aug 19, 2026
The packet queue's lifecycle is tied to both handshakes and session state, in ways that make it awkward for either to own the queue. Also delete a number of Session tests that are duplicative of Endpoint tests, and are becoming increasingly hard to make robust as the endpoint state machines become more entangled. Updates #339 Signed-off-by: David Anderson <danderson@tailscale.com> Change-Id: I2f7273fd3949c1a9f8bec3707438db356a6a6964
danderson
force-pushed
the
push-xksxswkmwqvq
branch
from
August 19, 2026 16:54
17dd11d to
824f17f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The packet queue's lifecycle is tied to both handshakes and session state, in ways that make it awkward for either to own the queue.
Also delete a number of Session tests that are duplicative of Endpoint tests, and are becoming increasingly hard to make robust as the endpoint state machines become more entangled.
Updates #339
Change-Id: I2f7273fd3949c1a9f8bec3707438db356a6a6964