ts_ffi: document the required layout of config.tags for ts_init - #392
Merged
Merged
Conversation
danderson
requested review from
dylan-tailscale,
npry and
nrc
as code owners
September 1, 2026 19:34
The tags field is a simple nul-terminated array of strings, which would be familiar to any C developer. However, since `ts_init` already has a safety comment that explicitly spells out the invariants for other fields, also spell out what nul-terminated arrays look like. Fixes #337 Signed-off-by: David Anderson <danderson@tailscale.com> Change-Id: I8cefdbc3e93b42b30d71ba8d338456846a6a6964
Signed-off-by: David Anderson <danderson@tailscale.com> Change-Id: I3fe5645d5744853a0e0f1422d9cbc3556a6a6964
danderson
force-pushed
the
push-rnlkmonwlqwo
branch
from
September 1, 2026 23:39
e554cef to
4850da1
Compare
Member
Author
|
nightly cargo fmt demanded a change to the formatting of a file in ts_peercapability. I threw that in as a separate commit. |
nrc
approved these changes
Sep 2, 2026
dylan-tailscale
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tags field is a simple nul-terminated array of strings, which would be familiar to any C developer. However, since
ts_initalready has a safety comment that explicitly spells out the invariants for other fields, also spell out what nul-terminated arrays look like.Fixes #337