Update to rust 1.98.1 - #395
Merged
Merged
Conversation
danderson
requested review from
dylan-tailscale,
npry and
nrc
as code owners
September 3, 2026 19:12
Signed-off-by: David Anderson <danderson@tailscale.com> Change-Id: I792fcb7f29f5e72e538c916ee08b8f776a6a6964
danderson
force-pushed
the
push-sqxknoskxqku
branch
from
September 3, 2026 19:20
02fa206 to
a8bae2d
Compare
dylan-tailscale
approved these changes
Sep 3, 2026
dylan-tailscale
left a comment
dylan-tailscale
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, interested to hear the results of the 1.92+ tests
Member
Author
|
cargo test is happy on 1.92. I didn't try the full gamut of features and vets and so on, since it takes quite a lot of time just to build and test everything. 1.93..1.96 is running now, but if 1.92 was happy I don't anticipate the intermediates having issues. |
Member
Author
|
Tests passed on 1.92..1.98. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to our CI's current+prev testing, I'm locally running
cargo testagainst all versions from 1.92 (our secret MSRV in Cargo.toml) and current, to make sure we still at least compile and pass basic tests on all versions. I won't merge until that's finished.