repo/style: remove superfluous #[inline]s - #412
Merged
Merged
Conversation
Our general style has been to avoid annotating with `#[inline]` because empirically, the compiler makes good choices without the hint and largely ignores it. Validated that the `ts_bart` and `ts_bitset` benchmarks aren't adversely affected: some noise, but largely no effect. Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: I859871eedde095eea04411f29d02f8aa6a6a6964
npry
requested review from
danderson,
dylan-tailscale and
nrc
as code owners
September 15, 2026 21:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our general style has been to avoid annotating with
#[inline]because empirically, the compiler makes good choices without the hint and largely ignores it.Validated that the
ts_bartandts_bitsetbenchmarks aren't adversely affected: some noise, but no obvious net effect (some better, some worse, +/- low single digit percents mostly).