Skip to content

ts_dataplane, ts_tunnel: fix reserved_zeroes check in could_be_wireguard #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dylan-tailscale merged 1 commit into from
Sep 16, 2026
Merged

ts_dataplane, ts_tunnel: fix reserved_zeroes check in could_be_wireguard #415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ts_dataplane/src/packet_ident.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@ impl PacketIdent {
/// Checks certain invariants that must be true if this is Wireguard; does not establish
/// conclusive proof.
pub fn could_be_wireguard(pkt: &[u8]) -> bool {
if pkt.len() < 5 {
// The smallest valid WireGuard packet is a `packet_data` message with a zero-byte payload.
if pkt.len() < 16 {
return false;
}

Expand All @@ -112,7 +113,7 @@ impl PacketIdent {
return false;
}

[0u8; 4] == pkt[1..=4]
[0u8; 3] == pkt[1..=3]
}
}

Expand Down