ts_control_serde: fix serialization of DerpMap::omit_default_regions - #416
Merged
Merged
Conversation
In JSON, the field will be named `omitDefaultRegions` (lowercase first character); previously, `DerpMap` deserialization expected `OmitDefaultRegions` (pascal case), so a deserialized `DerpMap::omit_default_regions` would always be `false`. Signed-off-by: Dylan Bargatze <dylan@tailscale.com>
dylan-tailscale
requested review from
danderson,
npry and
nrc
as code owners
September 16, 2026 20:54
Integration test on cut-down DerpMap to ensure we correctly parse/populate `DerpMap::omit_default_regions`. Signed-off-by: Dylan Bargatze <dylan@tailscale.com>
npry
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In JSON, the serialized field is named
omitDefaultRegions(lowercase first character); previously,DerpMapdeserialization expectedOmitDefaultRegions(pascal case), so a deserializedDerpMap::omit_default_regionswould always befalse.Thanks to @valkum for the report!
Closes #391.