Skip to content

chore: add changeset for #626 (dialog component types) #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepjoy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: add changeset for #626 (dialog component types) #634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/proper-dialog-component-types.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
"@ladle/react": patch
---

fix: add proper types for dialog components

Adds explicit prop types for `DialogOverlay` and `DialogContent` and removes
the `@ts-ignore` directives in the `Modal` component (the
[#626](https://github.com/tajo/ladle/pull/626) change). This unblocks
downstream consumers running stricter typecheckers — notably
[`@typescript/native-preview` (tsgo)](https://www.npmjs.com/package/@typescript/native-preview),
which surfaces the underlying `Property 'isOpen' does not exist on type
'IntrinsicAttributes & RefAttributes<unknown>'` error from
`typings-for-build/app/src/ui.tsx` even with `skipLibCheck: true`.
Loading