fix: resolve memory leaks from missing IDisposable implementations and undisposed resources#105
Draft
fix: resolve memory leaks from missing IDisposable implementations and undisposed resources#105
Conversation
… calls - DbDataReaderAsyncEnumerator2: store and dispose DbConnection in DisposeAsync - KafkaReceiverQueue: dispose _consumerStartSemaphore in Dispose - AzureServiceBusQueue: implement IDisposable to dispose SemaphoreSlim, ServiceBus resources - AzureEventHubReceiverQueue: implement IDisposable to dispose SemaphoreSlim and EventHubClient - Memory/SortedSet: implement IDisposable to dispose SemaphoreSlim - Sql/Mapping/Table: implement IDisposable to dispose SemaphoreSlim Co-authored-by: sylvester-henrique <19980165+sylvester-henrique@users.noreply.github.com>
…Disposable Co-authored-by: sylvester-henrique <19980165+sylvester-henrique@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Analyze code for potential memory leaks
fix: resolve memory leaks from missing IDisposable implementations and undisposed resources
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit of disposable resource handling found 6 leak sites — undisposed
SemaphoreSlim,DbConnection, and Azure ServiceBus resources.Critical
DbDataReaderAsyncEnumerator2—DbConnectionfrom factory was assigned to a local inMoveNextAsync()and never disposed. Stored as field; disposed inDisposeAsync(). Compare withDbDataReaderAsyncEnumeratorwhich already did this correctly.AzureServiceBusQueue— heldSemaphoreSlim,ServiceBusClient,ServiceBusSender,ServiceBusReceiverwith noIDisposable/IAsyncDisposable. Implemented both.AzureEventHubReceiverQueue— heldSemaphoreSlim+EventHubClientwith noIDisposable. Implemented.Medium
KafkaReceiverQueue—_consumerStartSemaphore.Dispose()missing fromDispose(bool). Sibling classes (KafkaEventStreamConsumer,KafkaSchemaRegistryReceiverQueue) already had this.Memory.SortedSet—SemaphoreSlimfield, noIDisposable. Implemented.Sql.Mapping.Table—SemaphoreSlimfield, noIDisposable. Implemented.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.