Make buildable MSVC 64bit#46
Open
chezou wants to merge 3 commits into
Open
Conversation
kou
reviewed
Nov 23, 2018
|
|
||
| #ifdef _WIN32 | ||
| #ifdef __GNUC__ | ||
| #if defined(_WIN32) && (defined(__GNUC__) || defined(_MSC_VER)) |
Contributor
There was a problem hiding this comment.
We need to convert path to wide characters from UTF-8 when we use WPATH_FORCE on both GCC and MSVC.
Author
This was referenced Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #13 merging, the MSVC build has been broken since
WPATH_FORCEis not defined for MSVC.This patch fixes
WPATH_FORCEfor MSVCconfigureis not available