Refactor/cv engine#119
Merged
Merged
Conversation
…verification workflow
DevUserSwitcher called queryClient.clear(), which destroys all Query objects and orphans the mounted useAuth() observer in AppHeader. The subsequent fetchQuery created a fresh query the observer never re-subscribed to, so the navbar kept the previous role until a full reload. Replace clear() + fetchQuery with invalidateQueries(), which marks queries stale and refetches active observers in place. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
CV scoring sections are static and defined in cv-scoring-config.ts, but staff could still author arbitrary categories on the enrollment-periods page (the source of stray "AAAA" entries). Make config the single source of truth: - EnrollmentPeriodService.create() now seeds MASTERS_SECTIONS and DOCTORAL_SECTIONS for the new period via CvScoringCategoryService, so every period gets the canonical categories automatically. - EnrollmentModule imports CvScoringModule (no circular dep). - enrollment-periods-page.tsx drops all category authoring (create/edit forms, copy-from-period dialogs, category validation, client batch create). The category panel is now read-only; period creation only takes name/semester/dates. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- enrollment-period.service: prettier import formatting - enrollment-period.service.spec: provide CvScoringCategoryService mock - enrollment-periods-page.tsx: prettier formatting Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
🎉 This PR is included in version 1.32.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.