Skip to content

[PR-24612] Upgrade SDK and App to Android 14 (API 35)#15

Open
Ararat777 wants to merge 18 commits intomasterfrom
pohosian-PR-24612
Open

[PR-24612] Upgrade SDK and App to Android 14 (API 35)#15
Ararat777 wants to merge 18 commits intomasterfrom
pohosian-PR-24612

Conversation

@Ararat777
Copy link

@Ararat777 Ararat777 commented Mar 10, 2026 •
edited
Loading

Related Stories

Summary

SDK Module

  • Upgraded compileSdkVersion and targetSdkVersion from 31 to 35
  • Upgraded Android Gradle Plugin to 8.5.2
  • Upgraded Gradle wrapper to 8.7
  • Upgraded buildToolsVersion to 36.0.0
  • Enabled AndroidX build features (buildconfig, nonFinalResIds, nonTransitiveRClass)
  • Bumped SDK version to 0.5.14 (version code 43)
  • Moved hardcoded build config (compileSdk, minSdk, targetSdk, buildTools) to gradle.properties

App Module

  • Upgraded compileSdkVersion and targetSdkVersion from 31 to 35
  • Raised minSdkVersion from 16 to 21
  • Upgraded buildToolsVersion to 36.0.0
  • Renamed applicationId from com.talkable.demo to com.talkable.appdemo
  • Moved all build config (compileSdk, minSdk, targetSdk, buildTools, versionCode, versionName) to gradle.properties for consistency with SDK module

Other

  • Updated README.md dependency version to 0.5.14
  • Upgraded de.mobilej.unmock plugin

dgtv
dgtv requested changes Mar 12, 2026
View reviewed changes
Copy link
Contributor

@dgtv dgtv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job! we just need to fix the versioning. Actually, this is a standard part of the updated and release process so it would be great to have some document with instructions how it should be done, so bot or human can follow it.

Please also improve PR name and add a description tha shows what has beed changed in SDK and App modules. Thanks

gradle.properties Outdated
Comment on lines +24 to +25
sdk_version_code=42
sdk_version_name=0.5.13
Copy link
Contributor

@dgtv dgtv Mar 12, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ararat777 as you've updated the SDK, Code and Name versions need to be updated here (+1, new next version). Also, you need to update all mentions of the version like in README.md file:

android-sdk/README.md

Line 27 in 73cc2dd

implementation 'com.github.talkable:android-sdk:0.5.12'

app/build.gradle Outdated
applicationId "com.talkable.appdemo"
minSdkVersion 21
targetSdkVersion 35
versionCode 35
Copy link
Contributor

@dgtv dgtv Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you've moved this configuration to gradle.properties in SDK module, in App module we need to be consistent and move necessary configuration to it too.

@Ararat777 Ararat777 changed the title [PR-24612] Upgrade App [PR-24612] Upgrade SDK and App to Android 14 (API 35) Mar 23, 2026
Ararat777 and others added 2 commits March 23, 2026 15:32
@Ararat777 @claude
Move build config to gradle.properties and bump SDK to 0.5.14
5f5ba78 
Centralize hardcoded build configuration (compileSdk, targetSdk, minSdk,
buildTools, versionCode, versionName) into gradle.properties for both
SDK and App modules. Bump SDK version to 0.5.14 (code 43) and update
README to reference the new version.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@Ararat777 @claude
Add release process documentation
ad4ff03 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@Ararat777 Ararat777 requested a review from dgtv March 26, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgtv dgtv Awaiting requested review from dgtv

Assignees

@dgtv dgtv

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ararat777 @dgtv @Doimhneacht