Push the scoop manifest into the bucket directory#52
Merged
Conversation
Without a directory the scoop manifest landed at the repository root, while the seeded manifests and the path scoop reads live under bucket/. A scoop install would keep resolving the stale root-shadowed manifest. Set directory: bucket so the release overwrites bucket/<tool>.json, the same place the manifest is served from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without a directory, GoReleaser pushed the scoop manifest to the repository root (file=.json), while the seeded manifests and the path scoop reads from live under bucket/. So a scoop install kept resolving the stale bucket/.json instead of the freshly released root one.
directory: bucket makes the release overwrite bucket/.json directly. The stray root manifests are cleaned up separately.