Dequarantine the brew cask binary on install#67
Merged
Merged
Conversation
Homebrew quarantines cask artifacts and Gatekeeper SIGKILLs quarantined binaries that are only ad-hoc signed, which cross-compiled Go binaries are. shirabe hit this first: brew install worked but the binary died with exit 137 until the attribute was stripped by hand. Add the same postflight xattr hook here so casks from the next release run first try.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same fix that landed on shirabe. Homebrew quarantines cask artifacts and Gatekeeper kills quarantined binaries that are only ad-hoc signed, which cross-compiled Go binaries are, so a fresh brew install of kage dies with exit 137 on first run.
This adds the postflight xattr hook to the cask config so the next release generates a cask that strips the attribute at install time. The live cask in the tap gets the same hook patched in directly.