Skip to content

the appender gate is about batching, not about a disk #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tamnd merged 1 commit into from
Aug 18, 2026
Merged

the appender gate is about batching, not about a disk #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tests/test_appender.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,8 +454,11 @@ def test_appending_beats_inserting_by_the_margin_that_makes_it_worth_having(

# Measured at about 150 times on this machine at this row count and
# rising with it, since one commit is one commit however many rows
# it carries. The gate is 20, which is the number that says the
# appender is still batching rather than the number it hits.
assert inserting > 20 * appending, (
# it carries. It is 18 on a shared CI runner, where a commit costs
# 25 ms of somebody else's disk and the appender's single one is
# most of what it spends, so the gate is 5: the number that says the
# appender is still batching rather than the number either machine
# hits.
assert inserting > 5 * appending, (
f"{COMPARED} rows: {inserting * 1000:.0f} ms inserted, {appending * 1000:.0f} ms appended"
)
Loading