Skip to content

Decimal is not re-exported from the zu crate, so every client depends on zu-common directly #773

Description

@tamnd

crates/zu/src/lib.rs:16 re-exports the value types a caller of this crate needs, and Decimal is not among them. zu::query::Value::Decimal holds a zu_common::Decimal, so a caller who matches on that arm cannot name the type they got without adding a second dependency:

zudb = { git = "...", rev = "..." }
zu-common = { git = "...", rev = "..." }

Both clients that support decimals do exactly that today. It works, and it makes the two pins something that has to be kept aligned by hand, which is the kind of thing that goes wrong quietly.

Temporal and DurationKind are in the same position and are already re-exported. Decimal should be too.

Found while adding decimal support to zu-python and zu-node.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions