Conversation
tamnd/zu-c#11 installs the kit in a container holding a compiler and nothing else, nightly, and runs both programs off the README against what it installed. Three rows, and the third is the one worth having: a machine with no CMake on it at all, which is the only honest way to check the claim that a header-only wrapper needs the include path and nothing else. Each row runs again with a piece taken out of the install, after the install rather than out of the source. Without the header the compile has to fail, without the CMake package find_package has to fail, without the engine the link has to fail. A build that still worked would be a build that found something on the image, and every pass would have meant nothing. Practice goes 78 to 89 over a denominator of 90. stability is the last item on the card and it is the one that keeps zu-c off the threshold.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tamnd/zu-c#11 installs the kit in a container holding a compiler and nothing else, nightly, and runs both programs off the README against what it installed.
The repository already had an install job, and it installed into a prefix and built
cmake/consumeragainst it on a runner where every tool is already present. That is worth having and it is not this item: it cannot tell you whether the install is self-sufficient, because nothing about it is clean.Three rows. A gcc image given cmake, a bare debian given a compiler and cmake, and a bare debian with no cmake on it at all. The third is the one worth having, because it is the only honest way to check the claim the page makes for a project that would rather not use CMake: a header-only wrapper needs the include path and nothing else, and an image with CMake on it cannot say so.
Both programs on the page are built and run, not just the C++ one. The C program needs nothing out of that repository, which is the point: it says the SDK a user was handed is enough on its own.
The half that a job like this usually leaves out is there. Each row runs again with a piece taken out of the install, after the install rather than out of the source. Without
zu.hppthe compile has to fail, without the CMake packagefind_packagehas to fail, without the engine the link has to fail. A build that still worked would be a build that found something on the image, and every pass would have meant nothing. All eight break runs were exercised on a box with docker and all eight failed for the reason they were supposed to.The image is checked rather than believed, the same way zu-go's is. The day a base image starts shipping a Rust toolchain is the day the job quietly stops being about anything.
Practice goes 78 to 89, over a denominator of 90.
stabilityis the last item on the card and it is what keeps zu-c off the threshold, soxtask clientsstill reports 4 of 5 tier 1 clients at it.