zu-c holds stability, which takes it to everything its tier asks for - #667
Merged
Merged
Conversation
tamnd/zu-c#12 landed api/surface.txt and the gate that reads it, so the last item on zu-c's card is held and the card is full. The number in the table is 100 rather than 90 because the column is a percentage of what the client's own tier asks of it, and zu-c is asked for neither api-map nor perf: it has no second surface to map, the header is the surface, and the numbers it would publish are the engine's rather than its own. Ninety points out of a denominator of ninety is a hundred percent, and it is the first client with nothing owed. That makes five tier 1 clients at their tier's threshold, which is the count the three boxes on DX4 wait on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tamnd/zu-c#12 landed
api/surface.txtand the gate that reads it, so the last item on zu-c's card is held.docs/surface.pywrites every nameinclude/zu.hpppublishes and the shape it publishes it in, out of the same Doxygen run the reference gate already does, and CI fails until a header change that moved the surface is accompanied by the regenerated file. It tells apart what went, what arrived and what changed shape, because a name that arrived is a minor release and a name that went is not, and identity there is the name plus the parameter types plus the const and ref qualifier, which is what a C++ overload actually is. A renamed parameter is not a change. A defaulted parameter added is a different overload and reads as one gone and one arrived, correctly.Landing it found a real hole the reference gate could not see. With
EXPAND_ONLY_PREDEFon, a#defineDoxygen reads in the file is not a value it will evaluate an#ifagainst, so every#if ZU_HAS_EXPECTEDblock was skipped and ninety twotry_members, the wholestd::expectedmirror, were published nowhere and warned about nowhere. A member the preprocessor threw away cannot be undocumented, soWARN_IF_UNDOCUMENTEDhad nothing to say about it.Connectionwent from 28 published members to 47. That is the fifth time in this repository a gate has been green over nothing, and it is written down in the Doxyfile beside the fix.The table
zu-c reads 100 rather than 90, and the reason is worth saying rather than looking like a typo. The column is a percentage of what the client's own tier asks of it, and zu-c is asked for neither
api-mapnorperf: it has no second surface to map, since the header is the surface, and the numbers it would publish are the engine's rather than its own. So its denominator is 90, and holding all ninety is a hundred percent. It is the first client with nothing owed.Five tier 1 clients are now at their tier's threshold, which is the count the three boxes on #170 wait on.
Checked
On server3, against the engine at HEAD:
And the gate was exercised rather than reasoned about: a method taken away reports one went and names it,
noexceptadded reports one changed shape, a return type changed reports one changed shape, an undeleted copy constructor reports one changed shape, a parameter renamed reports nothing at all, and the include guard put back intoPREDEFINEDreports that nothing was read out of the XML rather than reporting that the entire surface disappeared.