feat(netcli): expose VSTest crash diagnostics across supported wrappers - #6
Closed
be-student wants to merge 1 commit into
Closed
be-student wants to merge 1 commit into
be-student wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DotNetTestSettingsexposed hang diagnostics but could not request crash dumps through its typed API. AddBlameCrash, nullableBlameCrashDumpType, and fluent setters to the V8, V9, and V10 wrappers, which all share this missing VSTest option surface.Fixes #5.
Dump sizes are typed as
Mini/Fulland validated on assignment, including direct property assignment, so undefined enum values never become CLI arguments. Defaults remain unchanged; resetting the nullable setting omits its flag. Selecting a dump size retains VSTest's implicit crash-diagnostic behavior independently of the explicit flag. Existing hang settings still compose with both options.Validation:
dotnet test Tamp.slnx --no-restore: 3,616 passed, zero skipped, across the repository's .NET 8/9/10 matrix; no warnings or errors. A preceding full run restored all dependencies successfully.git diff --check: passed. Installed SDK help and Microsoft's VSTest documentation confirm the flag values and implication.Added a linked usage guide and XML documentation for the new API. These options are for VSTest, not Microsoft.Testing.Platform; actual dump generation remains platform/runtime dependent. No deliberate crash-dump run was performed. This PR was implemented, reviewed, and tested by an AI agent.