Skip to content

feat(netcli): expose VSTest crash diagnostics across supported wrappers - #6

Closed
be-student wants to merge 1 commit into
tamp-build:mainfrom
be-student:codex/5-blame-crash
Closed

be-student wants to merge 1 commit into
tamp-build:mainfrom
be-student:codex/5-blame-crash

Conversation

@be-student

Copy link
Copy Markdown

DotNetTestSettings exposed hang diagnostics but could not request crash dumps through its typed API. Add BlameCrash, nullable BlameCrashDumpType, and fluent setters to the V8, V9, and V10 wrappers, which all share this missing VSTest option surface.

Fixes #5.

Dump sizes are typed as Mini/Full and validated on assignment, including direct property assignment, so undefined enum values never become CLI arguments. Defaults remain unchanged; resetting the nullable setting omits its flag. Selecting a dump size retains VSTest's implicit crash-diagnostic behavior independently of the explicit flag. Existing hang settings still compose with both options.

Validation:

  • The new API regression initially failed to compile against the existing wrapper because the requested type/API was absent.
  • dotnet test Tamp.slnx --no-restore: 3,616 passed, zero skipped, across the repository's .NET 8/9/10 matrix; no warnings or errors. A preceding full run restored all dependencies successfully.
  • Tests cover boolean-only requests, both dump sizes, defaults/resets, coexistence with hang diagnostics, direct properties, and invalid values without losing the previous valid state. All three wrapper versions have the same coverage.
  • git diff --check: passed. Installed SDK help and Microsoft's VSTest documentation confirm the flag values and implication.

Added a linked usage guide and XML documentation for the new API. These options are for VSTest, not Microsoft.Testing.Platform; actual dump generation remains platform/runtime dependent. No deliberate crash-dump run was performed. This PR was implemented, reviewed, and tested by an AI agent.

@be-student be-student closed this Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add --blame-crash support to DotNetTestSettings

1 participant