Skip to content

chore(deps): move tnt-core-bindings to 0.19.1 (deployed 0.19 ABI)#1476

Merged
drewstone merged 1 commit into
mainfrom
chore/bump-tnt-bindings-0.19.1
Jul 24, 2026
Merged

chore(deps): move tnt-core-bindings to 0.19.1 (deployed 0.19 ABI)#1476
drewstone merged 1 commit into
mainfrom
chore/bump-tnt-bindings-0.19.1

Conversation

@drewstone

@drewstone drewstone commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Change Class

  • Class A (docs/tooling only)
  • Class B (single-crate behavior)
  • Class C (cross-crate/runtime behavior)
  • Class D (protocol/security/metadata semantics)
  • Selected class: Class B
  • Why this class: dependency lock bump with local blast radius — no crate source or public API changes; the tnt-core-bindings = "0.19" caret already admitted 0.19.1, only Cargo.lock moves.

Behavior Contract

Risk and Scope

  • Security impact: none introduced; removes an ABI-mismatch risk that could mis-decode on-chain data.
  • Compatibility impact (APIs, metadata format, configs): aligns the on-chain ABI the binary uses with the deployed contract; no blueprint public API / metadata / config change.
  • Migration notes (if any): none — transparent lock bump; caret consumers pick up 0.19.1 on their next update.
  • Rollback plan: revert the Cargo.lock change (restores 0.19.0).

Verification

List the exact commands you ran and outcomes.

cargo update -p tnt-core-bindings                          # 0.19.0 -> 0.19.1
cargo check -p blueprint-qos -p blueprint-x402 --locked    # Rust 1.91, the only direct consumers
# -> Finished in 2m25s, 0 errors (compiles clean against the new ABI)

Harness Evidence

  • Reproducer added/updated: n/a — dependency lock bump.
  • Negative-path coverage added: n/a — a selector mismatch is a compile-time failure, exercised by the consumer build above.
  • Key assertions that prove the fix: blueprint-qos + blueprint-x402 compile against tnt-core-bindings 0.19.1.

Checklist

  • I followed docs/engineering/HARNESS_ENGINEERING_PLAYBOOK.md.
  • I followed docs/engineering/HARNESS_ENGINEERING_SPEC.md.
  • I used docs/engineering/HARNESS_REVIEW_CHECKLIST.md while implementing/reviewing.
  • I added or updated tests that reproduce the original issue. — n/a: dependency lock bump, no source change. The original issue (stale ABI) is reproduced by the version diff itself and caught at compile time.
  • I added or updated negative-path tests for invalid/missing/conflicting input. — n/a: a selector mismatch is a compile-time failure, exercised by the consumer build below.
  • I documented behavior or interface changes in docs/examples when needed. — n/a: no interface change; the ABI rationale is documented in tnt-core's bindings/CHANGELOG.md 0.19.1.
  • I evaluated compatibility/migration impact explicitly. — see Risk and Scope; the "0.19" caret already admitted 0.19.1.
  • I validated local formatting, clippy, and relevant tests. — cargo check -p blueprint-qos -p blueprint-x402 --locked green (the two direct consumers).

Note on CI: blueprint-manager / Integration Tests / two cargo test matrices are already red on main (8bdd362f) before this change — verified via the check-runs on the main commit. This lock-only bump does not touch them.

crates.io tnt-core-bindings 0.19.0 was stale — published before tnt-core #209
regenerated the ABI, so it lacks the EventDriven settlement-asset billing
selectors of the live 0.19 deployment. 0.19.1 carries the deployed ABI.

The '\''0.19'\'' caret already admits 0.19.1; this moves the lock so blueprint's
own binaries (blueprint-manager) build against the deployed contract instead
of the stale selectors. blueprint-qos + blueprint-x402 (the only direct
consumers) compile clean against 0.19.1.

@tangletools tangletools left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved drewstone PR — be382f27

This PR was opened by the trusted drewstone account.
The full PR reviewer audit still runs separately and will publish findings if it detects issues.

tangletools · auto-approval · reason: drewstone_author · 2026-07-24T21:36:11Z

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown

PR Quality Gate Summary

  • Status: pass
  • Selected class: Class B
  • Required class: Class B
  • Reason: Code changes detected with local blast radius.
  • Changed files: 1

@tangletools

Copy link
Copy Markdown
Contributor

✅ No Blockers — be382f27

Review health 100/100 · Reviewer score 95/100 · Confidence 65/100 · 0 findings (none)

glm: Correctness 95 · Security 95 · Testing 95 · Architecture 95

Reviewer score is advisory once the run is complete and the verdict has no blockers.

Full multi-shot audit completed 1/1 planned shots over 1 changed files. Global verifier still owns final merge decision.

No findings.


tangletools · 2026-07-24T21:39:09Z · trace

@tangletools tangletools left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Clean — be382f27

Full multi-shot audit completed 1/1 planned shots over 1 changed files. Global verifier still owns final merge decision.

Full immutable report for this review: trace

Summary comment for this run: full summary


tangletools · 2026-07-24T21:39:09Z · immutable trace

@drewstone
drewstone merged commit cf8aabc into main Jul 24, 2026
26 of 33 checks passed
@drewstone
drewstone deleted the chore/bump-tnt-bindings-0.19.1 branch July 24, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants