Open
Conversation
Member
|
Notes from discussion with @patriciogonzalezvivo:
|
Member
|
You could put the 'brick' tiling pattern into the SDF texture as well, to further simplify the shader! |
Contributor
Author
|
Yes @blair1618 ! that's next on my TODO... I will wait for this PR to merge so I don't introduce a lot of changes at once. cc @nvkelso @bcamper @sensescape |
Contributor
Author
…s before refactor tiny-dots are not showing up, force them to be medium in the mean time
Member
|
@patriciogonzalezvivo can you help @sensescape and I debug why |
This reverts commit c4e8243.
Contributor
Author
|
hi @nvkelso, not sure what you need. seams like an old PR that wasn't merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a
sdf-shapethat could be reused for other styles. How it works?u_sdffillorstrokeshapecirclefunction with itWe now can do more complex patterns if we want : )