Skip to content

Conversation

@YamingPei
Copy link
Contributor

Description

taos shell (cli) supports dsn with user/password.

Issue(s)

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

@YamingPei YamingPei requested review from a team, guanshengliang and zitsen as code owners December 8, 2025 07:10
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @YamingPei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the taos CLI, allowing users to specify authentication credentials directly within the Data Source Name (DSN). This change simplifies connection strings for the command-line tool, making it more convenient and secure to connect to TDengine instances requiring user authentication. The underlying connection logic has been refactored to utilize a more robust DSN parsing mechanism, and comprehensive testing has been added to ensure the reliability of this new feature.

Highlights

  • DSN with User/Password Support: The taos command-line interface (CLI) now fully supports Data Source Names (DSNs) that include embedded username and password credentials, enhancing connection flexibility and security.
  • Simplified DSN Connection Logic: The internal DSN connection handling in shellEngine.c has been streamlined by leveraging the taos_connect_with_dsn function, removing redundant custom DSN parsing logic.
  • New Test Case for DSN Authentication: A new test case has been added to test_tool_taos_cli.py to validate the functionality of connecting via DSNs that specify both a username and password.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for DSNs with embedded user and password credentials in the taos CLI. The implementation refactors the connection logic in shellEngine.c to delegate DSN parsing to the taos_connect_with_dsn function from the client library. This is a good simplification, making the shell's connection logic cleaner and more robust by separating DSN handling from parameter-based connections. A corresponding test case has been added in test_tool_taos_cli.py to verify the new functionality. The changes are well-implemented and improve the code's maintainability.

@YamingPei
Copy link
Contributor Author

image 失败 case 与 PR 无关

@zitsen zitsen merged commit e8b25e5 into main Dec 9, 2025
14 of 15 checks passed
@zitsen zitsen deleted the feat/TS-6495051884 branch December 9, 2025 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants