Add ambitap.room~ — the object line is complete (16 externals)#5
Merged
Merged
Conversation
…16 objects Wraps the library's new dsp::room (merged upstream: the C++ render passes the same R1-R10 harness that selected its FDN architecture — worst T20 +6.0%, order balance 0.16 dB, IACC dev 0.079, byte-identical determinism). ambitap.room~ <order> (max 3): mono source in -> HOA bus out carrying direct path + shoebox image-source early reflections + the 16-line FDN tail. Attributes dim_x/y/z, source_x/y/z, listener_x/y/z, rt60 (plus rt60band and reflections messages), direct/er/tail toggles, gain; fixed ~53 ms latency at 48 kHz documented in the help patch (injection alignment inherent to the verified design). Submodule bumped to AmbiTap main with dsp/room.h + generated seed tables. README: room~ entry, Wave 3 marked code complete (listening pass still owed by the perceptual objects). CI bundle count 15 -> 16; all 16 compile against the bumped pin. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012VeadvCRUHJdneFNwRbFAM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The last object in the ROADMAP's Wave 3 line. Wraps the library's new
dsp::room(merged in tap/AmbiTap#13, where the C++ render passes the same R1–R10 harness that selected its FDN architecture — worst T20 +6.0%, order balance 0.16 dB, IACC deviation 0.079, byte-identical determinism).ambitap.room~ <order>(max 3): mono source in → HOA bus out carrying direct path + shoebox image-source early reflections + the 16-line SH-domain FDN tail. Attributes:dim_x/y/z,source_x/y/z,listener_x/y/z,rt60(plusrt60band <hz> <sec>andreflections <6 floats>messages),direct/er/tailtoggles,gain. Geometry/RT60 changes rebuild off-thread with crossfaded adoption; the fixed ~53 ms latency at 48 kHz (injection alignment inherent to the verified design) is documented in the help patch, withlatency_samples()exposed upstream for hosts that compensate.Also: submodule bump, README entry + Wave 3 marked code complete, CI bundle count 15 → 16.
Test plan
dsp::roomverified against the notebook gates (141/141 library tests, both compilers under WERROR)xtc~androom~, before a release🤖 Generated with Claude Code
https://claude.ai/code/session_012VeadvCRUHJdneFNwRbFAM
Generated by Claude Code