Normalize multiline FTP source contracts - #42
Merged
Merged
Conversation
Make the FTP certificate regression contract independent of CRLF versus LF checkout state by normalizing datacon1.cpp before multiline assertions. This keeps the Build Installer NativeSafety gate focused on the required source structure instead of platform-specific line endings.
Contributor
There was a problem hiding this comment.
Pull request overview
Normalizes FTP source line endings so multiline regression assertions work consistently across LF and CRLF checkouts.
Changes:
- Converts
datacon1.cppline endings to LF before assertions.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the FTP certificate regression contract independent of CRLF versus LF checkout state by normalizing datacon1.cpp before multiline assertions.
This keeps the Build Installer NativeSafety gate focused on the required source structure instead of platform-specific line endings.