Added new tests to main branch - #43
Closed
PatrykLs98 wants to merge 10 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the FileManager UI test suite with new “reported defect” characterization coverage, improves test stability for TLS/SChannel handshakes, and tightens CI/toolchain setup for mixed-architecture builds (plus a small native safety fix in redirected-directory handling).
Changes:
- Added new characterization UI tests (ZIP navigation after info dialog; HTML Help Search result contract) plus supporting settings/command IDs.
- Hardened SChannel TLS integration tests to avoid indefinite hangs by enforcing shared handshake deadlines and improved cleanup.
- Updated PR MSBuild workflow + VS Build Tools environment setup for correct x86/x64 targeting in the matrix, and fixed a native UTF-8→UTF-16 conversion validity edge case.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/setup-vs2026-buildtools.ps1 | Adds target-architecture selection for VsDevCmd export; avoids PATH pollution while still validating x86 MASM presence. |
| tests/FileManager.UiTests/SChannelTlsIntegrationTests.cs | Adds handshake timeout/cancellation and cleanup; adjusts certificate loading behavior. |
| tests/FileManager.UiTests/ReportedDefectCharacterizationUiTests.cs | New UI characterization tests for ZIP open flow + HTML Help Search. |
| tests/FileManager.UiTests/README.md | Updates documentation to describe new lanes/fixtures and the new runner script. |
| tests/FileManager.UiTests/Infrastructure/UiTestSettings.cs | Adds opt-in gates for ZIP plug-in and Help Search fixture inputs. |
| tests/FileManager.UiTests/Infrastructure/NativeCommands.cs | Adds stable command IDs for Open and Help Search plus a helper to submit Help Search via Enter. |
| src/fileswindow_navigation.cpp | Rejects invalid UTF-8→UTF-16 conversions before redirected-dir comparison and preserves display spelling safely. |
| run-ui-tests.ps1 | Adds a focused local runner that sets up an isolated sandbox and validates the selected artifact. |
| .github/workflows/pr-msbuild.yml | Targets VsDevCmd per-matrix platform and adds environment/tool-resolution verification before building. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
151
to
162
| # Match the tool host to the matrix row as a defense against runner-specific x64 library-path leakage. | ||
| $preferredToolArchitecture = if ('${{ matrix.platform }}' -eq 'Win32') { 'x86' } else { 'x64' } | ||
|
|
||
| $arguments = @( | ||
| $env:SOLUTION_PATH | ||
| '/m' | ||
| '/t:Rebuild' | ||
| "/p:Configuration=$($env:BUILD_CONFIGURATION)" | ||
| "/p:Platform=${{ matrix.platform }}" | ||
| "/p:PlatformToolset=$($env:PLATFORM_TOOLSET)" | ||
| '/p:PreferredToolArchitecture=x64' | ||
| "/p:PreferredToolArchitecture=$preferredToolArchitecture" | ||
| '/warnaserror' |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.