Upgrade to net10 - #14
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Upgrades the WindowLoggerConfigGui WinForms project from .NET Framework 4.8 to .NET 10 (windows) and updates the associated upgrade scenario documentation/configuration for the solution.
Changes:
- Retarget
WindowLoggerConfigGuitonet10.0-windowsand bumpSystem.Text.Jsonto10.0.3. - Replace/expand
WindowAnalyser/appsettings.jsonwith a much larger application/category ruleset. - Add .NET 10 upgrade scenario artifacts under
.github/upgrades/scenarios/new-dotnet-version_ab2cb1/.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
WindowLoggerConfigGui/WindowLoggerConfigGui.csproj |
Retargets Config GUI to net10.0-windows and updates System.Text.Json package version. |
WindowAnalyser/appsettings.json |
Expands application/category matching configuration used by the analyser. |
.github/upgrades/scenarios/new-dotnet-version_ab2cb1/tasks.md |
Tracks upgrade checklist/progress for the .NET 10 migration scenario. |
.github/upgrades/scenarios/new-dotnet-version_ab2cb1/scenario.json |
Adds scenario metadata for the .NET version upgrade operation. |
.github/upgrades/scenarios/new-dotnet-version_ab2cb1/plan.md |
Adds the written upgrade plan and validation steps for the migration. |
.github/upgrades/scenarios/new-dotnet-version_ab2cb1/execution-log.md |
Logs prerequisite verification results for the upgrade. |
.github/upgrades/scenarios/new-dotnet-version_ab2cb1/assessment.md |
Adds compatibility assessment output for projects/packages/APIs for .NET 10. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <PropertyGroup> | ||
| <OutputType>WinExe</OutputType> | ||
| <TargetFramework>net48</TargetFramework> | ||
| <TargetFramework>net10.0-windows</TargetFramework> |
Comment on lines
+84
to
+86
| "name": "Whatsapp", | ||
| "include": [ "Whatsapp" ], | ||
| "exclude": [] |
| "exclude": [] | ||
| }, | ||
| { | ||
| "name": "Open Salamnder", |
|
|
||
| ## Migration Strategy | ||
| **Approach: All-At-Once (atomic)** | ||
| - Rationale: Small solution (4 projects), shallow dependency graph (tray depends on the other three), only one project requires TF/pacakge change. Coordinated update minimizes multi-targeting overhead. |
Comment on lines
+24
to
+25
| - [ ] (1) Update WindowLoggerConfigGui target framework to net10.0-windows with Windows Desktop support per Plan §Project-by-Project Plans | ||
| - [ ] (2) Update System.Text.Json package from 10.0.2 to 10.0.3 in WindowLoggerConfigGui per Plan §Package Update Reference |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.