This repository was archived by the owner on Nov 5, 2025. It is now read-only.
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request represents a major refactor and modernization of the rrule library, transitioning from version 2.8.0 to 3.0.0. The PR includes comprehensive code formatting updates, TypeScript configuration improvements, build system modernization, and infrastructure changes.
Key Changes:
- Build System Modernization: Removed Webpack build configuration in favor of a simpler TypeScript-only build, updated package metadata (now
@taskworld/rrule), and migrated to pnpm - Code Formatting: Applied consistent trailing comma formatting across all TypeScript test and source files
- Import Organization: Reordered imports alphabetically in several files for consistency
- Infrastructure Updates: New GitHub Actions workflows for pre-merge and post-merge checks, removed old CI configuration, and added formatter configuration (
.oxfmtrc.json)
Reviewed Changes
Copilot reviewed 45 out of 50 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated package name to @taskworld/rrule, version to 3.0.0, simplified build scripts, removed webpack dependencies, added pnpm |
| webpack.config.js | Removed entire webpack configuration (deleted file) |
| tsconfig.json | Modernized TypeScript configuration with updated module settings and stricter options |
| tsconfig.build.json | Simplified by extending base tsconfig and reducing duplicate configuration |
| bower.json | Removed bower support (deleted file) |
| test/**/*.test.ts | Applied consistent trailing comma formatting across all test files |
| src/**/*.ts | Applied trailing commas and reordered imports in source files |
| .github/workflows/* | Added new pre-merge and post-merge workflows, removed old nodejs.yml workflow |
| .oxfmtrc.json | Added new formatter configuration |
| .npmrc | Added GitHub package registry configuration |
| .eslintrc.js, .prettierignore, etc. | Removed various linting/formatting config files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR content
Notes
tests are still passing locally, let's see about ci