Skip to content

docs(amos-next): mandate Opus for staleness + flag-and-verify review gate - #45

Merged
tato123 merged 1 commit into
mainfrom
docs/amos-next-opus-mandate-and-flag-verify
Apr 28, 2026
Merged

tato123 merged 1 commit into
mainfrom
docs/amos-next-opus-mandate-and-flag-verify

Conversation

@tato123

@tato123 tato123 commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Two updates to .claude/skills/amos-next/SKILL.md:

  • Step 2.5 (staleness check) — Opus is mandatory; subagents spawned for verification must pass `model: "opus"`. Max-effort reads, no skim. Treat AI Agent Notes as hard-won research; default to "the body is right and current code is the drift" on contradictions and only flip when evidence is unambiguous. Spawn parallel Opus `general-purpose` agents (single message) for non-trivial verification; `Explore` is for narrow lookups only. Architectural disagreement between the body and fresh analysis pauses for user input before the plan locks.
  • Step 7 (pre-PR review) — the `pr-review-gate` reviewer (Opus) flags concerns; the session agent verifies each one against actual code and owns the final judgment. PASS/FIX/DISCUSS verdicts are advisory recommendations, not binding decisions. Even on PASS, the session agent independently spot-checks issue-body fidelity, behavior preservation, and test quality. The session agent must leave Step 7 with complete understanding of the issue and current code and high confidence the work is correct — or dig further / ask the user.

Why

Sonnet defaults applied CLAUDE.md naming rules mechanically in a recent review and flagged names that came verbatim from an issue body — wasted attention. On architecture-flavored issues, Sonnet risks overriding hard-won research the user deliberately captured in AI Agent Notes. Opus everywhere reasoning is needed, with the session agent as the final decision-maker, fixes both failure modes.

Test plan

  • Updated SKILL.md is syntactically intact (Markdown renders, no broken sections).
  • Already in use locally (`~/.claude/skills/amos-next/SKILL.md`) — exercised against streamlib PR #557 just before this change. Verdict from the new flag-and-verify path: independent verification of 7 substantive claims, all confirmed against actual code, PASS confidence high.
  • After merge: `scripts/install.sh` syncs to `~/.claude/skills/amos-next/SKILL.md` for any new install.

🤖 Generated with Claude Code

…rotocol for review gate

Two changes to `.claude/skills/amos-next/SKILL.md`:

**Step 2.5 (staleness check)** — make Opus mandatory and explicit:

- Reasoning-heavy step; never falls back to Sonnet. Whenever a
  subagent is spawned for verification, pass `model: "opus"`.
- Use max effort: full reads, not skim. Treat AI Agent Notes as
  hard-won research the user wants preserved, not suggestions to
  override.
- Default direction on contradictions is "the body is right, current
  code is the drift" — flip only when evidence is unambiguous.
- For non-trivial verification spawn parallel Opus
  general-purpose subagents (one per concern, in a single message).
  `subagent_type=Explore` is for narrow lookups only.
- When body research disagrees with fresh analysis on architecture
  specifically (not file paths or method names), pause and surface
  to the user before locking the plan.

**Step 7 (pre-PR review)** — advisory verdict, session-agent owns
the final judgment:

- The pr-review-gate skill (spawns an Opus reviewer) flags concerns;
  the session agent verifies each one against actual code and
  decides what to do.
- PASS / FIX / DISCUSS are reviewer recommendations, not binding.
- Even on PASS, independently spot-check issue-body fidelity,
  behavior preservation, and test quality before opening the PR.
- The session agent should leave Step 7 with complete understanding
  of the issue and current code, and high confidence the body of
  work is correct. If not, dig further or surface to the user.

Why: Sonnet defaults applied CLAUDE.md naming rules mechanically in
a recent review and flagged names that came verbatim from an issue
body — wasted attention. Worse, on architecture-flavored issues,
Sonnet risks overriding hard-won research the user deliberately
captured. Opus everywhere reasoning is needed, with the session
agent as the final decision-maker, fixes both.
@tato123
tato123 merged commit 0cea59c into main Apr 28, 2026
1 check passed
tato123 added a commit that referenced this pull request Jul 29, 2026
It lived only in ~/.claude as an untracked copy — usable on one
machine, lost on reinstall, and invisible to the installer that
provisions every other skill. amos-next has invoked it as a mandatory
step since #45, so a skill the workflow depends on was the one skill
not shipped with the workflow.

Carries the P0 priority gate added in 011d6c1: a reviewer flagging
something is agent-initiated by definition — it is a tool the agent
invoked, not the user asking for a ticket. Verifying a finding is real
settles whether it is true, not whether it is worth tracking. Hard rule
6 scopes the skill's autonomy to the open-PR decision and nothing else.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant