Fix for CUDA 12 nvtx3 library detection #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses CUDA 12 compatibility issues by implementing a workaround for PyTorch's NVTX library detection. The fix creates an alias from the legacy CUDA::nvToolsExt target to the newer CUDA::nvtx3 target when using CUDA 12 or later, ensuring PyTorch can properly link against the NVTX profiling library.
- Adds version check for CUDA compiler version 12 and above
- Creates
CUDA::nvToolsExtinterface target as alias toCUDA::nvtx3when needed - Sets
TORCH_CUDA_USE_NVTX3compile definition to enable PyTorch NVTX3 support
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #25 #24 #23
Fix inspired by https://discuss.pytorch.org/t/failed-to-find-nvtoolsext/179635/13