Remove once-cell-regex from dependencies#500
Merged
Merged
Conversation
Member
|
as much as i hate macros, i don't think this is an equivalent replacement. The macro/crate will create a new function for each call while your function approach will make it re-use the same regex for all calls after the first. |
Contributor
Author
|
That was an unforced, dumb mistake.. |
FabianLars
approved these changes
Jan 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
once-cell-regexis a tiny crate that doesn't need to be a dependency, the functions are simple enough to inline into the crate.This is a very, very small contribution towards the auditability of Tauri, which has a lot of dependencies.