fix: regression detecting Android process PID with app ID suffix#509
Merged
Conversation
regression from #505 ## Summary Fix Android `run_with_application_id_suffix` so the suffixed application id is used consistently for both launching the activity and resolving the running process for logcat. This prevents debug/release side-by-side installs from attaching logcat to the wrong package, and avoids waiting on the base package when only the suffixed variant is running. ## Test plan - `cargo test android::device::test::test_resolve_activity_name` - `cargo fmt --check`
Contributor
Package Changes Through 7f5f1e8There are 1 changes which include cargo-mobile2 with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
regression from #505
Fix Android
run_with_application_id_suffixso the suffixed application id is used consistently for both launching the activity and resolving the running process for logcat.This prevents debug/release side-by-side installs from attaching logcat to the wrong package, and avoids waiting on the base package when only the suffixed variant is running.