fix: KillProcess should push 0 when nothing found#49
Merged
amrbashir merged 2 commits intoNov 2, 2025
Conversation
amrbashir
reviewed
Nov 1, 2025
Member
amrbashir
left a comment
amrbashir
left a comment
There was a problem hiding this comment.
I think we should return a totally different return value, for example 3 indicating there were no processes found with the provided name, which we can still choose to ignore in tauri bundler and treat it as success
Contributor
Author
|
Changed to return |
amrbashir
approved these changes
Nov 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KillProcessandKillProcessCurrentUserwill be pushing 0 to the stack instead of 1 when no processes were foundThe idea behind
KillProcessis to kill all the processes with the given name, so if we didn't find anything, it should just return success since everything with that name are now killed, at least that's the case for our use cases (or alternatively we could return something else to indicate this)Fix
tauri-apps/tauri#14400