feat(window): add command to set fullscreen on specific monitor#14926
feat(window): add command to set fullscreen on specific monitor#14926Oscar3170 wants to merge 1 commit into
Conversation
|
The naming and function parameters could cause confusion, since the other set_fullscreen functions can set the fullscreen state on or off, while this new function only sets fullscreen on. I figured it would be best to leave the job of turning off the fullscreen state to the regular set_fullscreen function, since the monitor is irrelevant in this case. Be free to give feedback on if I should change the name or add a bool parameter to the function. |
|
Hi, Severity: action required | Category: correctness How to fix: Return error when monitor missing Agent prompt to fix - you can give this to your LLM of choice:
We noticed a couple of other issues in this PR as well - happy to share if helpful. Qodo code review - free for open-source. |
Add a new command to the window core plugin
set_fullscreen_on_monitorwhich receives a position and sets the window as fullscreen on the monitor that contains the position.Since tao already exposes a way to specify the monitor for the fullscreen function, it was only necessary to expose this parameter in the tauri-runtime-wry and window plugin.
Since monitor names are not unique the new function needs the monitor's position to know which monitor we actually want.
This is the most useful on wayland systems, since the window can't move itself any other way, and this at least gives an option for applications that need to be fullscreen.
Workaround for issues: #14019 and #7376.