fix(stacking): align siblings horizontally#8
Merged
Conversation
tauseefk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(stacking): align siblings horizontally and expand shallow subtrees
[conjecture] Horizontal alignment of siblings cannot be calculated merely from the following attributes of a node:
I don't fully agree with this, if I have a left offset, and know how many nodes need to be laid out in each branch, it should be possible to calculate their width. However, the robot disagrees.
So, in this current solution, I store the height of the entire cluster (all subtrees) at each node to determine it's left offset. The subtree depth still determines the width of each node.