fix(userscripts): fix parsePrice thousands separator edge cases in toppreise script - #32
Conversation
…g logic - Refactored `parsePrice` to correctly distinguish between thousands separators and decimal dots/commas based on string position. - Fixed a bug in `processProductDetailPage` where a recursive call failed because the `isProcessingDetail` lock wasn't released early enough. - Stabilized flakey behavior in `test_deal_score_weight_preset_dropdown_in_filter_bar` by adding explicit waits for the popover element. Co-authored-by: tazztone <62671577+tazztone@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Changed parsePrice to use a deterministic routine counting digits after the final separator, allowing correct support for various thousands/decimal formatting variants without missing digits. - Exported parsePrice for direct unit testing and added comprehensive test cases covering different inputs in test_userscript.py. - Fixed the Playwright test `test_deal_score_weight_preset_dropdown_in_filter_bar` flake by replacing time-based waits and forced clicks with state-based visibility assertions. - Reverted the accidental commit of node_modules and other related build folders. Co-authored-by: tazztone <62671577+tazztone@users.noreply.github.com>
1 participant
parsePriceto correctly distinguish between thousands separators and decimal dots/commas based on string position. This fixes cases where1.385.90and1,385.90returned incorrect values.processProductDetailPagewhere a recursive call failed because theisProcessingDetaillock wasn't released early enough, preventing the deal badge from rendering on product detail pages.test_deal_score_weight_preset_dropdown_in_filter_barby adding explicit waits for the popover element in Playwright tests.PR created automatically by Jules for task 6449553026944624772 started by @tazztone